Bug 2253359 - Review Request: zstr - A C++ header-only ZLib wrapper
Summary: Review Request: zstr - A C++ header-only ZLib wrapper
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/mateidavid/zstr
Whiteboard:
Depends On:
Blocks: 2253363
TreeView+ depends on / blocked
 
Reported: 2023-12-06 21:46 UTC by Jerry James
Modified: 2024-01-09 22:37 UTC (History)
2 users (show)

Fixed In Version: zstr-1.0.7-1.fc40
Clone Of:
Environment:
Last Closed: 2024-01-09 22:37:23 UTC
Type: ---
Embargoed:
gwync: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2023-12-06 21:46:29 UTC
Spec URL: https://jjames.fedorapeople.org/zstr/zstr.spec
SRPM URL: https://jjames.fedorapeople.org/zstr/zstr-1.0.7-1.fc40.src.rpm
Fedora Account System Username: jjames
Description: This C++ header-only library enables the use of C++ standard iostreams to access ZLib-compressed streams.

For input access (decompression), the compression format is auto-detected, and multiple concatenated compressed streams are decompressed seamlessly.

For output access (compression), the only parameter exposed by this API is the compression level.

This package is part of an effort to add the SoPlex and SCIP solvers to Fedora.  The entire collection of packages is available in a COPR: https://copr.fedorainfracloud.org/coprs/jjames/SCIP/.

Comment 1 Fedora Review Service 2023-12-06 21:53:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6729879
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253359-zstr/fedora-rawhide-x86_64/06729879-zstr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Gwyn Ciesla 2024-01-09 21:03:27 UTC
rpmlint is clean
naming is OK
meets packaging guidelines
License related items are all OK
Spec is legible, in American English
Source hashes match
Builds locally and in mock on x86_64, BuildRequires are sound.
No locales.
Nothing bundled
Not relocatable
Ownership is good.
No duplicates.
Permissions are good.
Macro usage is good.
Contains permissable code.
Docs handled approprately.
No static libraries.
-devel only package.
No .la
No GUI apps
No cross-ownership.
All ASCII filenames.
No requirement of deprecated packages.

Looks great to me!
APPROVED

Comment 3 Jerry James 2024-01-09 22:19:12 UTC
Thank you for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-09 22:21:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/zstr

Comment 5 Jerry James 2024-01-09 22:37:23 UTC
This package has been built in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.