Bug 225345
| Summary: | Review Request: kodos - Visual regular expression editor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Ryabitsev <icon> |
| Component: | Package Review | Assignee: | Orion Poplawski <orion> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | Flags: | orion:
fedora-review+
kevin: fedora-cvs+ |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-17 17:13:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Konstantin Ryabitsev
2007-01-29 23:51:51 UTC
Mostly looks good, full review to follow but thought I'd note this first: # rpmlint -i kodos E: kodos non-executable-script /usr/lib/python2.4/site-packages/kodos/kodos.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. I think you want to pull the shebang. Or, perhaps not even package it as it is basically the same as /usr/bin/kodos? mock build fails: + desktop-file-install --vendor fedora --dir /var/tmp/kodos-2.4.9-1.fc6-root-mockbuild/usr/share/applications --add-category X-Fedora /builddir/build/SOURCES/kodos.desktop /var/tmp/rpm-tmp.24776: line 36: desktop-file-install: command not found Looks like you need: BuildRequires: desktop-file-utils I apologize for the delay. This is tested to build in mock, pass all rpmlint checks, and known to work. :) http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-2.fc6.src.rpm Good:
- rpmlint checks return:
*
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
Worrisome:
- There is no license/copyright/author information in the source files
themselves. Please ping upstream about getting this added. Not a blocker per
se, since the project clearly inteads to be GPLv2.
Fix:
- No need for X-Fedora in desktop-file-install
- No need for update-desktop-database - no MimeType key in .desktop file
(http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28update-desktop-database%29#head-de6770dd9867fcd085a73a4700f6bcd0d10294ef)
Sorry for the delay, again. I swear it will be speedy from now on. :) http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-3.el5.wsg.src.rpm Cheers! Looks good to me. I would change:
%{_bindir}/*
%{python_sitelib}/*
%{_datadir}/applications/*
to:
%{_bindir}/kodos
%{_python_sitelib}/kodos/
%{_datadir}/applications/fedora-kodos.desktop
because personally I like to list things out. Helps detect when things change.
But I'll leave that up to your preference.
APPROVED
New Package CVS Request ======================= Package Name: kodos Short Description: Visual regular expression editor Owners: icon Branches: FC-6 F-7 EL-5 InitialCC: cvs done. From cvs commit log: Requires(post): desktop-file-utils Requires(postun): desktop-file-utils However, there is no %post or %postun. Thanks, everyone! |