Bug 2253720
| Summary: | Review Request: rust-crypto-auditing-log-parser - Event log parser for crypto-auditing project | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> | ||||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 38 | CC: | decathorpe, package-review | ||||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| URL: | https://crates.io/crates/crypto-auditing-log-parser | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2023-12-15 01:51:44 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2253714 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Daiki Ueno
2023-12-09 00:43:20 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6735775 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06735775-rust-crypto-auditing-log-parser/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-log-parser/rust-crypto-auditing-log-parser.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-log-parser/rust-crypto-auditing-log-parser-0.2.1-1.fc40.src.rpm [fedora-review-service-build] Created attachment 2004039 [details]
The .spec file difference from Copr build 6735775 to 6747008
Copr build: https://copr.fedorainfracloud.org/coprs/build/6747008 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06747008-rust-crypto-auditing-log-parser/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-log-parser/rust-crypto-auditing-log-parser.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-log-parser/rust-crypto-auditing-log-parser-0.2.1-1.fc40.src.rpm [fedora-review-service-build] Created attachment 2004206 [details]
The .spec file difference from Copr build 6747008 to 6750973
Copr build: https://copr.fedorainfracloud.org/coprs/build/6750973 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06750973-rust-crypto-auditing-log-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ? test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification (GPL-3.0-or-later) and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === PS: "(Apache-2.0 OR MIT) AND (MIT OR Apache-2.0)" is redundant, the SPDX "OR" operator is cummutative. I usually only keep the occurrence that sorts "earlier alphabetically", and omit any other permutations. That makes license tags at least a bit shorter. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto-auditing-log-parser Thank you for the review! The package has been imported and built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5e88dcd68c |