Bug 2253720 - Review Request: rust-crypto-auditing-log-parser - Event log parser for crypto-auditing project
Summary: Review Request: rust-crypto-auditing-log-parser - Event log parser for crypto...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/crypto-audit...
Whiteboard:
Depends On: 2253714
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-09 00:43 UTC by Daiki Ueno
Modified: 2023-12-15 01:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-15 01:51:44 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6735775 to 6747008 (773 bytes, patch)
2023-12-13 01:37 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6747008 to 6750973 (459 bytes, patch)
2023-12-13 23:46 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2023-12-09 00:46:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6735775
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06735775-rust-crypto-auditing-log-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-12-13 01:37:22 UTC
Created attachment 2004039 [details]
The .spec file difference from Copr build 6735775 to 6747008

Comment 4 Fedora Review Service 2023-12-13 01:37:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6747008
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06747008-rust-crypto-auditing-log-parser/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2023-12-13 23:46:43 UTC
Created attachment 2004206 [details]
The .spec file difference from Copr build 6747008 to 6750973

Comment 7 Fedora Review Service 2023-12-13 23:46:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6750973
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253720-rust-crypto-auditing-log-parser/fedora-rawhide-x86_64/06750973-rust-crypto-auditing-log-parser/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fabio Valentini 2023-12-14 15:47:42 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
? test suite is run and all unit tests pass (there are no tests)
- latest version of the crate is packaged
- license matches upstream specification (GPL-3.0-or-later) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

PS: "(Apache-2.0 OR MIT) AND (MIT OR Apache-2.0)" is redundant, the SPDX "OR" operator is cummutative. I usually only keep the occurrence that sorts "earlier alphabetically", and omit any other permutations. That makes license tags at least a bit shorter.

Comment 9 Fedora Admin user for bugzilla script actions 2023-12-14 23:02:47 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto-auditing-log-parser

Comment 10 Daiki Ueno 2023-12-15 01:51:44 UTC
Thank you for the review! The package has been imported and built in rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-5e88dcd68c


Note You need to log in before you can comment on or make changes to this bug.