Bug 2253806

Summary:	Review Request: akonadi-contacts - The Akonadi Contacts Library
Product:	[Fedora] Fedora	Reporter:	Steve Cossette <farchord>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-10 01:48:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Steve Cossette 2023-12-09 22:28:04 UTC

Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts-24.01.80-1.fc39.src.rpm

Description:
The Akonadi Contacts Library.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110119929

Fedora Account System Username: farchord

Comment 1 Neal Gompa 2023-12-09 22:31:17 UTC

Taking this review.

Comment 2 Neal Gompa 2023-12-09 22:33:55 UTC

Spec review:

> # handled by qt6-srpm-macros, which defines %%qt6_qtwebengine_arches
> %{?qt6_qtwebengine_arches:ExclusiveArch: %{qt6_qtwebengine_arches}}

This should be dropped, since it doesn't depend on QtWebEngine

> BuildRequires:  cmake(Qt6WebEngineQuick)

This is not a dependency. QtWebEngine was dropped as a dependency six years ago: https://invent.kde.org/pim/akonadi-contacts/-/commit/32c9536a24224b28027d764a9c2968480b0425a0

You should re-evaluate the dependency list based on the CMakeLists: https://invent.kde.org/pim/akonadi-contacts/-/blob/master/CMakeLists.txt?ref_type=heads

Comment 3 Steve Cossette 2023-12-09 23:39:08 UTC

Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts-24.01.80-1.fc39.src.rpm

Cleaned up the build requires

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110121965

Comment 4 Neal Gompa 2023-12-10 00:05:35 UTC

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Steve Cossette 2023-12-10 01:47:17 UTC

Thank you for the review, Neal

Comment 6 Fedora Admin user for bugzilla script actions 2023-12-10 01:47:28 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-contacts