Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts-24.01.80-1.fc39.src.rpm Description: The Akonadi Contacts Library. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110119929 Fedora Account System Username: farchord
Taking this review.
Spec review: > # handled by qt6-srpm-macros, which defines %%qt6_qtwebengine_arches > %{?qt6_qtwebengine_arches:ExclusiveArch: %{qt6_qtwebengine_arches}} This should be dropped, since it doesn't depend on QtWebEngine > BuildRequires: cmake(Qt6WebEngineQuick) This is not a dependency. QtWebEngine was dropped as a dependency six years ago: https://invent.kde.org/pim/akonadi-contacts/-/commit/32c9536a24224b28027d764a9c2968480b0425a0 You should re-evaluate the dependency list based on the CMakeLists: https://invent.kde.org/pim/akonadi-contacts/-/blob/master/CMakeLists.txt?ref_type=heads
Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts.spec SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-contacts/akonadi-contacts-24.01.80-1.fc39.src.rpm Cleaned up the build requires Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110121965
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal
The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-contacts