Bug 2254095

Summary: Review Request: akonadi-search - The Akonadi Search library and indexing agent
Product: [Fedora] Fedora Reporter: Steve Cossette <farchord>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-12-11 22:12:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Steve Cossette 2023-12-11 22:09:07 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-search/akonadi-search.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-search/akonadi-search-24.01.80-1.fc39.src.rpm

Description:
The Akonadi Search library and indexing agent.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110204581

Fedora Account System Username: farchord

Comment 1 Neal Gompa 2023-12-11 22:11:25 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 2 Steve Cossette 2023-12-11 22:12:19 UTC
Thank you for the review, Neal

Comment 3 Fedora Admin user for bugzilla script actions 2023-12-11 22:12:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-search

Comment 4 Fabio Valentini 2023-12-12 23:33:26 UTC
> * Package licensing is correctly handled

This is incorrect. The package contains statically linked code from various Rust libraries. At a quick glance, some of them are "MIT" licensed, others are "MIT OR Apache-2.0" licensed, neither of which are present in the license tag in the package.

You can use the "%cargo_license" and "%cargo_license_summary" macros (in the directory that contains the sub-project's Cargo.toml file) to generate the list of licenses of Rust crates that get statically linked into the final binary.