Bug 2254095 - Review Request: akonadi-search - The Akonadi Search library and indexing agent
Summary: Review Request: akonadi-search - The Akonadi Search library and indexing agent
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-11 22:09 UTC by Steve Cossette
Modified: 2023-12-12 23:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-11 22:12:51 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-12-11 22:09:07 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/akonadi-search/akonadi-search.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/akonadi-search/akonadi-search-24.01.80-1.fc39.src.rpm

Description:
The Akonadi Search library and indexing agent.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110204581

Fedora Account System Username: farchord

Comment 1 Neal Gompa 2023-12-11 22:11:25 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 2 Steve Cossette 2023-12-11 22:12:19 UTC
Thank you for the review, Neal

Comment 3 Fedora Admin user for bugzilla script actions 2023-12-11 22:12:31 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/akonadi-search

Comment 4 Fabio Valentini 2023-12-12 23:33:26 UTC
> * Package licensing is correctly handled

This is incorrect. The package contains statically linked code from various Rust libraries. At a quick glance, some of them are "MIT" licensed, others are "MIT OR Apache-2.0" licensed, neither of which are present in the license tag in the package.

You can use the "%cargo_license" and "%cargo_license_summary" macros (in the directory that contains the sub-project's Cargo.toml file) to generate the list of licenses of Rust crates that get statically linked into the final binary.


Note You need to log in before you can comment on or make changes to this bug.