Bug 225447

Summary:	Review Request: php-magpierss - MagpieRSS is an RSS parser written in PHP
Product:	[Fedora] Fedora	Reporter:	Michael Stahnke <mastahnke>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	j: fedora-review+ wtogami: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-05-24 02:17:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	225434
Bug Blocks:

Description Michael Stahnke 2007-01-30 17:45:32 UTC

Spec URL: http://www.stahnkage.com/rpms/php-magpierss.spec
SRPM URL: http://www.stahnkage.com/rpms/php-magpierss-0.72-1.src.rpm
Description: MagpieRSS is a set of php files designed to parse RSS XML for usage in PHP code.
MagpieRSS is compatible with RSS 0.9 through RSS 1.0.

Comment 1 Michael Stahnke 2007-01-30 18:52:06 UTC

I think I am going to change the install path for this and make the review
dependent on bug #225434.

Comment 2 Michael Stahnke 2007-01-30 18:57:25 UTC

Update:

SPEC URL: http://www.stahnkage.com/rpms/php-magpierss.spec
SRPM URL: http://www.stahnkage.com/rpms/php-magpierss-0.72-2.src.rpm

Comment 3 Jason Tibbitts 2007-05-06 04:03:26 UTC

Well, hey, the blocker bug is fixed now, so I'll take a look.

Comment 4 Jason Tibbitts 2007-05-06 06:16:08 UTC

Well, there's not much to this package.  rpmlint is completely silent.

A couple of minor issues:

The indentation in %description looks a little odd.
There's no need for the leading slash here:
  /%{_datadir}/php/magpierss/

I don't think these are blockers.

* source files match upstream:
   7cf9698ade1067d19c4c551529928b70bdc270fd7c450c4eba883a17ac4614c3
   magpierss-0.72.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none needed)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-magpierss = 0.72-2.fc7
  =
   php
* %check is not present; no test suite upstream.
* owns the directories it creates.
   /usr/share/php comes from php-common, which is a dependency of php.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 5 Michael Stahnke 2007-05-06 16:25:51 UTC

New Package CVS Request
=======================
Package Name: php-magpierss
Short Description: MagpieRSS is an RSS parser written in PHP
Owners: stahnma
Branches:  FC-6, F7, devel, EL4, EL5

Comment 6 Jason Tibbitts 2007-05-15 17:46:38 UTC

Please don't forget to close this bug once the package has been imported and built.