Bug 2254534

Summary:	Review Request: rust-hickory-client - Hickory DNS is a safe and secure DNS library
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Aleksei Bavshin <alebastr89>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	alebastr89, package-review
Target Milestone:	---	Flags:	alebastr89: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/hickory-client
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-12-19 22:00:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2254532
Bug Blocks:

Description Fabio Valentini 2023-12-14 11:58:09 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-hickory-client.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-hickory-client-0.24.0-1.fc39.src.rpm

Description:
Hickory DNS is a safe and secure DNS library. This is the Client library
with DNSSEC support. DNSSEC with NSEC validation for negative records,
is complete. The client supports dynamic DNS with SIG0 authenticated
requests, implementing easy to use high level funtions. Hickory DNS is
based on the Tokio and Futures libraries, which means it should be
easily integrated into other software that also use those libraries.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-12-14 12:02:31 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6752863
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254534-rust-hickory-client/fedora-rawhide-x86_64/06752863-rust-hickory-client/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Aleksei Bavshin 2023-12-19 02:44:03 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fabio Valentini 2023-12-19 16:37:34 UTC

Thank you for the review!

Comment 4 Fedora Admin user for bugzilla script actions 2023-12-19 16:54:26 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hickory-client

Comment 5 Fedora Update System 2023-12-19 21:57:01 UTC

FEDORA-2023-be20762fb8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-be20762fb8

Comment 6 Fedora Update System 2023-12-19 22:00:42 UTC

FEDORA-2023-be20762fb8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.