Bug 2254532 - Review Request: rust-hickory-proto - Hickory DNS is a safe and secure DNS library
Summary: Review Request: rust-hickory-proto - Hickory DNS is a safe and secure DNS lib...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Aleksei Bavshin
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/hickory-proto
Depends On:
Blocks: 2254533 2254534
TreeView+ depends on / blocked
Reported: 2023-12-14 11:55 UTC by Fabio Valentini
Modified: 2023-12-19 22:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2023-12-19 22:00:34 UTC
Type: ---
alebastr89: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 11:55:02 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-hickory-proto.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-hickory-proto-0.24.0-1.fc39.src.rpm

Hickory DNS is a safe and secure DNS library. This is the foundational
DNS protocol library for all Hickory DNS projects.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-14 11:55:06 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110326120

Comment 2 Fedora Review Service 2023-12-14 12:54:57 UTC
Copr build:

Review template:

Please take a look if any issues were found.

This comment was created by the fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Aleksei Bavshin 2023-12-19 02:32:28 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines


Consider applying https://github.com/hickory-dns/hickory-dns/commit/b0c05664837684d74d396dae8cceb6171ea4c556 to fix the optional `ring` and `dnssec-ring` features after ring version bump.

Comment 4 Fabio Valentini 2023-12-19 16:37:13 UTC
Thank you for the review!

I'll look into applying the linked patch before importing the package.

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-19 16:50:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hickory-proto

Comment 6 Fedora Update System 2023-12-19 21:56:55 UTC
FEDORA-2023-be20762fb8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-be20762fb8

Comment 7 Fedora Update System 2023-12-19 22:00:34 UTC
FEDORA-2023-be20762fb8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.