Bug 2254615
| Summary: | Review Request: elementary-files - File manager from elementary | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/elementary/%{srcname} | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-12-21 20:10:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1512217 | ||
|
Description
Fabio Valentini
2023-12-14 21:39:33 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=110346580 Copr build: https://copr.fedorainfracloud.org/coprs/build/6758086 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254615-elementary-files/fedora-rawhide-x86_64/06758086-elementary-files/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-files Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in elementary-files-portal Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package (mostly) follows Fedora Packaging Guidelines + Please add "BuildRequires: gcc" on import * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint Other notes: Is there a preferred polkit agent? If so, maybe a "Suggests" for that should be added... This can be done on import if you wish. PACKAGE APPROVED. Thanks for the review! I'll add BR: gcc before unretiring the package. Preferred polkit agent is likely https://github.com/elementary/pantheon-agent-polkit I'll add Suggests for it as soon as it's back in Fedora. Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4e570c70cc |