Spec URL: https://decathorpe.fedorapeople.org/elementary-files.spec SRPM URL: https://decathorpe.fedorapeople.org/elementary-files-6.5.3-1.fc39.src.rpm Description: The simple, powerful, and sexy file manager from elementary. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=110346580
Copr build: https://copr.fedorainfracloud.org/coprs/build/6758086 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254615-elementary-files/fedora-rawhide-x86_64/06758086-elementary-files/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-files Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names - Systemd user unit service file(s) in elementary-files-portal Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package (mostly) follows Fedora Packaging Guidelines + Please add "BuildRequires: gcc" on import * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint Other notes: Is there a preferred polkit agent? If so, maybe a "Suggests" for that should be added... This can be done on import if you wish. PACKAGE APPROVED.
Thanks for the review! I'll add BR: gcc before unretiring the package. Preferred polkit agent is likely https://github.com/elementary/pantheon-agent-polkit I'll add Suggests for it as soon as it's back in Fedora.
https://pagure.io/releng/issue/11842
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-4e570c70cc