Bug 2254733

Summary:	Review Request: python-sciris - Fast, flexible tools to simplify scientific Python
Product:	[Fedora] Fedora	Reporter:	nerdsville.fas
Component:	Package Review	Assignee:	Tom Rix <trix>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	nerdsville.fas, package-review, sanjay.ankur, trix, xavier
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	xavier: fedora-review?
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-14 00:45:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	201449, 1276941

Description nerdsville.fas 2023-12-15 16:05:06 UTC

This is my first package and it is for the Compneuro SIG -- please also exercise extra scrutiny during the review process - thanks!

Spec URL: https://nerdsville.fedorapeople.org/python-sciris.spec
SRPM URL: https://nerdsville.fedorapeople.org/python-sciris-3.1.2-1.fc40.src.rpm
Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=110384164

Description: Sciris is a library of tools that can help make writing scientific Python code easier and more pleasant.

Documentation is available at: https://sciris.readthedocs.io/

Fedora Account System Username: nerdsville

Comment 1 Fedora Review Service 2023-12-15 16:13:31 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760502
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254733-python-sciris/fedora-rawhide-x86_64/06760502-python-sciris/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom Rix 2023-12-31 14:24:27 UTC

These are new packaging guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
Sometimes there is a good reason to use the old guidelines, is there one in this case ?

%description could be improved by more of the readme.

Sciris is a library of tools that can help make writing scientific Python code easier and more pleasant. Built on top of NumPy and Matplotlib, Sciris provides functions covering a wide range of common math, file I/O, and plotting operations. This means you can get more done with less code, and spend less time looking things up on Stack Overflow. It was originally written to help epidemiologists and neuroscientists focus on doing science, rather than on writing coding, but Sciris is applicable across scientific domains (and some nonscientific ones too).

%license should be 'MIT AND ISC'
Review the output of licensecheck.txt for ansicolors.py

A lot will change when you switch to the new guidelines so i am reserving comments for the new version.

Comment 3 Tom Rix 2024-01-14 16:53:41 UTC

Making sure you saw that your package is being reviewed.
If you need help poke me.

Comment 4 Package Review 2024-02-14 00:45:25 UTC

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Comment 5 nerdsville.fas 2024-02-23 10:38:35 UTC

Picking this up again - thank you for your feedback!