Bug 2254742

Summary: Review Request: rust-sudo - Detect if you are running as root
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/sudo
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-02 05:41:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2254784    

Description Davide Cavalca 2023-12-15 17:27:28 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sudo/rust-sudo.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sudo/rust-sudo-0.6.0-1.fc39.src.rpm

Description:
Detect if you are running as root, restart self with sudo if needed or
setup uid zero when running with the SUID flag set.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-12-15 17:27:31 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110386444

Comment 2 Fedora Review Service 2023-12-15 17:33:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760587
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254742-rust-sudo/fedora-rawhide-x86_64/06760587-rust-sudo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2023-12-15 22:01:31 UTC
MIT license text missing, can you ask upstream / send a PR to include it?

Comment 5 Michel Lind 2023-12-16 18:28:27 UTC
You need to list the MIT license too

%license %{crate_instdir}/LICENSE-MIT

Comment 6 Davide Cavalca 2023-12-16 22:56:03 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-sudo/rust-sudo.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-sudo/rust-sudo-0.6.0-1.fc40.src.rpm

Changelog:
- add license text to the file list at well

Comment 7 Michel Lind 2023-12-17 15:59:25 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 8 Fedora Admin user for bugzilla script actions 2023-12-17 17:12:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sudo

Comment 9 Fedora Update System 2023-12-17 17:55:15 UTC
FEDORA-2023-d8b145d1a4 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d8b145d1a4

Comment 10 Fedora Update System 2023-12-17 17:57:10 UTC
FEDORA-2023-d8b145d1a4 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-12-17 18:31:50 UTC
FEDORA-2023-1b199d32e6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1b199d32e6

Comment 12 Fedora Update System 2023-12-17 18:36:38 UTC
FEDORA-2023-240d562e75 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-240d562e75

Comment 13 Fedora Update System 2023-12-18 01:04:45 UTC
FEDORA-2023-240d562e75 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-240d562e75 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-240d562e75

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-12-18 02:03:57 UTC
FEDORA-2023-1b199d32e6 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2023-12-26 01:12:01 UTC
FEDORA-2023-240d562e75 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.