Bug 2254784 - Review Request: rust-startup-disk - Interface to choose the startup volume on Apple Silicon systems
Summary: Review Request: rust-startup-disk - Interface to choose the startup volume on...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/startup-disk
Whiteboard:
Depends On: 2254742
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-15 23:45 UTC by Davide Cavalca
Modified: 2024-01-02 05:41 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-02 05:41:09 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-12-15 23:45:36 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-startup-disk/rust-startup-disk.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-startup-disk/rust-startup-disk-0.1.2-1.fc39.src.rpm

Description:
Startup Disk provides a simple interface to choose the startup volume on Apple
Silicon Macs running Asahi Linux.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-12-15 23:48:46 UTC
Note: this will fail to build in copr because the sidetag updating rust-glib-build-tools (f40-build-side-79678) is not merged yet

Comment 2 Davide Cavalca 2023-12-16 01:49:41 UTC
This is the rust2rpm.toml I used here:

[package]
description = """
Startup Disk provides a simple interface to choose the startup volume on Apple
Silicon Macs running Asahi Linux."""

[requires]
build = ["make"]
bin = [
  "hicolor-icon-theme",
  "polkit",
  "sudo",
]
test = ["desktop-file-utils", "libappstream-glib"]

Comment 3 Fedora Review Service 2023-12-16 23:28:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6763277
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254784-rust-startup-disk/fedora-rawhide-x86_64/06763277-rust-startup-disk/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Michel Lind 2023-12-17 16:22:29 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-17 17:12:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-startup-disk

Comment 6 Fedora Update System 2023-12-17 17:55:19 UTC
FEDORA-2023-d8b145d1a4 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d8b145d1a4

Comment 7 Fedora Update System 2023-12-17 17:57:12 UTC
FEDORA-2023-d8b145d1a4 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-12-17 18:31:53 UTC
FEDORA-2023-1b199d32e6 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-1b199d32e6

Comment 9 Fedora Update System 2023-12-18 02:04:00 UTC
FEDORA-2023-1b199d32e6 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.