Bug 2254773

Summary: Review Request: rust-mock_instant - Simple way to mock an std::time::Instant
Product: [Fedora] Fedora Reporter: Albert Larsan <albertlarsan>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://crates.io/crates/mock_instant
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-18 17:15:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2257209    

Description Albert Larsan 2023-12-15 21:16:09 UTC
Spec URL: https://albertlarsan.fr/fedpkgs/rust-mock_instant/rust-mock_instant.spec
SRPM URL: https://albertlarsan.fr/fedpkgs/rust-mock_instant/rust-mock_instant-0.3.1-1.fc40.src.rpm
Description: Simple way to mock an std::time::Instant
Fedora Account System Username: albertlarsna68

Depencency for rust-adblock

Comment 1 Fedora Review Service 2023-12-15 21:21:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6760840
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254773-rust-mock_instant/fedora-rawhide-x86_64/06760840-rust-mock_instant/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Michel Lind 2024-01-07 23:46:04 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (0BSD) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Fedora Admin user for bugzilla script actions 2024-01-18 16:59:21 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mock_instant

Comment 4 Fedora Update System 2024-01-18 17:14:21 UTC
FEDORA-2024-ae18a6876b has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ae18a6876b

Comment 5 Fedora Update System 2024-01-18 17:15:31 UTC
FEDORA-2024-ae18a6876b has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2024-01-19 17:37:58 UTC
FEDORA-2024-d7e32bd78c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d7e32bd78c

Comment 7 Fedora Update System 2024-01-19 17:38:36 UTC
FEDORA-2024-ffeee5ac61 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ffeee5ac61

Comment 8 Fedora Update System 2024-01-20 03:25:12 UTC
FEDORA-2024-d7e32bd78c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d7e32bd78c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d7e32bd78c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-01-20 04:25:26 UTC
FEDORA-2024-ffeee5ac61 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ffeee5ac61 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ffeee5ac61

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-01-28 03:07:53 UTC
FEDORA-2024-d7e32bd78c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-01-29 04:30:15 UTC
FEDORA-2024-ffeee5ac61 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.