Spec URL: https://salimma.fedorapeople.org/rust-notify-debouncer-full.spec SRPM URL: https://salimma.fedorapeople.org/rust-notify-debouncer-full-0.3.1-1.fc38.src.rpm Description: Notify event debouncer optimized for ease of use. Fedora Account System Username: salimma
Four minor issues that don't block the review, but please address them: 1. The uploaded spec file and spec file extracted from uploaded srpm are different: @@ -14,5 +14,4 @@ Source: %{crates_source} # Manually created patch for downstream crate metadata changes -# * bump rstest from 0.17.0 to 0.18.0 Patch: notify-debouncer-full-fix-metadata.diff Please ensure to import the version that has that comment. 2. Please submit that change as a PR for upstream, if the change has not already been applied there. 3. W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/notify-debouncer-full-0.3.1/README.md Use something like "dos2unix --keepdate" to convert the file to unix line endings. 4. The "test_cases" directory should probably be excluded from packaged files. You can use %exclude %{crate_instdir}/test_cases/ in the %files section of the -devel subpackage. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
(In reply to Fabio Valentini from comment #1) > Four minor issues that don't block the review, but please address them: > > 1. The uploaded spec file and spec file extracted from uploaded srpm are > different: > > @@ -14,5 +14,4 @@ > Source: %{crates_source} > # Manually created patch for downstream crate metadata changes > -# * bump rstest from 0.17.0 to 0.18.0 > Patch: notify-debouncer-full-fix-metadata.diff > > Please ensure to import the version that has that comment. Ack, sorry. Must have forgotten to regenerate the SRPM > > 2. Please submit that change as a PR for upstream, if the change has not > already been applied there. > Done: https://github.com/notify-rs/notify/pull/556 > 3. W: wrong-file-end-of-line-encoding > /usr/share/cargo/registry/notify-debouncer-full-0.3.1/README.md > > Use something like "dos2unix --keepdate" to convert the file to unix line > endings. > Will do, thanks. adding a BR on dos2unix then (thanks rust2rpm.toml) > 4. The "test_cases" directory should probably be excluded from packaged > files. > > You can use %exclude %{crate_instdir}/test_cases/ in the %files section of > the -devel subpackage.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-notify-debouncer-full
FEDORA-2024-8fb9982b47 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8fb9982b47
FEDORA-2024-8fb9982b47 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-d7e32bd78c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d7e32bd78c
FEDORA-2024-ffeee5ac61 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ffeee5ac61
FEDORA-2024-d7e32bd78c has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d7e32bd78c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d7e32bd78c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ffeee5ac61 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ffeee5ac61 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ffeee5ac61 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-d7e32bd78c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-ffeee5ac61 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.