Bug 2254902

Summary:	skopeo: Build tags apparently not set correctly
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	skopeo	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amurdaca, bbaude, container-sig, dwalsh, go-sig, jnovy, kwalker, lsm5, pehunt
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	skopeo-1.14.1-1.fc38 skopeo-1.14.2-1.fc39	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-29 04:30:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2137512

Description Florian Weimer 2023-12-17 19:39:05 UTC

The spec file contains this:

BASEBUILDTAGS="$(hack/libdm_tag.sh) $(hack/libsubid_tag.sh)"

And apparently the hack/libsubid_tag.sh script runs a few more times during the build. However, the script always fails because the function is called subid_get_uid_ranges these days. I'm not sure if this has any functionality impact on the generated binaries, though.

Reproducible: Always

Comment 1 Florian Weimer 2023-12-17 19:40:15 UTC

And if you fix the script to print a build tag, you must also include <stdlib.h> for the free function because we are disabling support for implicit function declarations by default.

Comment 2 Lokesh Mandvekar 2024-01-05 12:38:22 UTC

WIP PR at https://github.com/containers/skopeo/pull/2190

Comment 3 Lokesh Mandvekar 2024-01-17 10:56:55 UTC

(In reply to Lokesh Mandvekar from comment #2)
> WIP PR at https://github.com/containers/skopeo/pull/2190

This has been fixed upstream. We'll try to get an upstream release and rpm build out soon.

Comment 4 Fedora Update System 2024-01-23 11:40:30 UTC

FEDORA-2024-67ef848d9f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-67ef848d9f

Comment 5 Fedora Update System 2024-01-23 11:41:08 UTC

FEDORA-2024-1db604c231 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1db604c231

Comment 6 Fedora Update System 2024-01-29 04:30:07 UTC

FEDORA-2024-1db604c231 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-02-03 00:49:10 UTC

FEDORA-2024-2c802021c9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2c802021c9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2c802021c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-02-18 00:55:23 UTC

FEDORA-2024-2c802021c9 (skopeo-1.14.2-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.