Bug 2254902 - skopeo: Build tags apparently not set correctly
Summary: skopeo: Build tags apparently not set correctly
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: skopeo
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2023-12-17 19:39 UTC by Florian Weimer
Modified: 2024-02-18 00:55 UTC (History)
9 users (show)

Fixed In Version: skopeo-1.14.1-1.fc38 skopeo-1.14.2-1.fc39
Clone Of:
Environment:
Last Closed: 2024-01-29 04:30:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Florian Weimer 2023-12-17 19:39:05 UTC
The spec file contains this:

BASEBUILDTAGS="$(hack/libdm_tag.sh) $(hack/libsubid_tag.sh)"

And apparently the hack/libsubid_tag.sh script runs a few more times during the build. However, the script always fails because the function is called subid_get_uid_ranges these days. I'm not sure if this has any functionality impact on the generated binaries, though.

Reproducible: Always

Comment 1 Florian Weimer 2023-12-17 19:40:15 UTC
And if you fix the script to print a build tag, you must also include <stdlib.h> for the free function because we are disabling support for implicit function declarations by default.

Comment 2 Lokesh Mandvekar 2024-01-05 12:38:22 UTC
WIP PR at https://github.com/containers/skopeo/pull/2190

Comment 3 Lokesh Mandvekar 2024-01-17 10:56:55 UTC
(In reply to Lokesh Mandvekar from comment #2)
> WIP PR at https://github.com/containers/skopeo/pull/2190

This has been fixed upstream. We'll try to get an upstream release and rpm build out soon.

Comment 4 Fedora Update System 2024-01-23 11:40:30 UTC
FEDORA-2024-67ef848d9f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-67ef848d9f

Comment 5 Fedora Update System 2024-01-23 11:41:08 UTC
FEDORA-2024-1db604c231 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1db604c231

Comment 6 Fedora Update System 2024-01-29 04:30:07 UTC
FEDORA-2024-1db604c231 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-02-03 00:49:10 UTC
FEDORA-2024-2c802021c9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2c802021c9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2c802021c9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-02-18 00:55:23 UTC
FEDORA-2024-2c802021c9 (skopeo-1.14.2-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.