Bug 2254926
| Summary: | Review Request: perl-AnyEvent-Connector - Tcp_connect with transparent proxy handling | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Adams <linux> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-05-24 01:03:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2254918 | ||
| Bug Blocks: | 2254930 | ||
|
Description
Chris Adams
2023-12-17 22:50:51 UTC
Note: depends on perl-Module-Build-Prereqs-FromCPANfile (review BZ 2254918) Bumped release for spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector-0.04-2.fc39.src.rpm Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector-0.04-3.fc39.src.rpm Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector.spec SRPM URL: https://cmadams.fedorapeople.org/perl-AnyEvent-Connector/perl-AnyEvent-Connector-0.04-4.fc39.src.rpm URL and Source0 addresses are Ok.
Source0 archive (SHA-512 83de0576b5d2ea7c3757fa5b4279463055be3c043cab5256a0adc44d0a20d9b7e826fa97cc8c92110ed8758af4af2bd0d8601c852188f9526d71f8bf12324b98) is original. Ok.
Summary verified from lib/AnyEvent/Connector.pm.
TODO: "Tcp_connect" is cryptic in the summary. It stands for AnyEvent::Socket::tcp_connect(). I recommend replacing "Tcp_connect" with general "TCP connect". Another option is long "AnyEvent::Socket::tcp_connect".
Description verified from lib/AnyEvent/Connector.pm. Ok.
License verified from Build.PL, README, and lib/AnyEvent/Connector.pm. Ok.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
$ rpmlint perl-AnyEvent-Connector.spec ../SRPMS/perl-AnyEvent-Connector-0.04-4.fc41.src.rpm ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-AnyEvent-Connector.noarch: E: spelling-error ('Tcp', 'Summary(en_US) Tcp -> Tc, Twp, Tc p')
perl-AnyEvent-Connector.src: E: spelling-error ('Tcp', 'Summary(en_US) Tcp -> Tc, Twp, Tc p')
=== 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 8 filtered, 2 badness; has taken 0.3 s ==
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/doc/perl-AnyEvent-Connector
-rw-r--r-- 1 root root 439 Nov 7 2023 /usr/share/doc/perl-AnyEvent-Connector/Changes
-rw-r--r-- 1 root root 1610 Nov 7 2023 /usr/share/doc/perl-AnyEvent-Connector/README
-rw-r--r-- 1 root root 2884 Mar 8 01:00 /usr/share/man/man3/AnyEvent::Connector.3pm.gz
-rw-r--r-- 1 root root 916 Mar 8 01:00 /usr/share/man/man3/AnyEvent::Connector::Proxy::http.3pm.gz
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector
-rw-r--r-- 1 root root 7721 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector.pm
drwxr-xr-x 2 root root 0 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector/Proxy
-rw-r--r-- 1 root root 1977 Mar 8 01:00 /usr/share/perl5/vendor_perl/AnyEvent/Connector/Proxy/http.pm
FIX: Package %{perl_vendorlib}/AnyEvent directory. None of the dependencies deliver it.
$ rpm -q --requires -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm | sort -f | uniq -c
1 perl(AnyEvent::Connector::Proxy::http)
1 perl(AnyEvent::Handle)
1 perl(AnyEvent::Socket)
1 perl(Carp)
1 perl(strict)
1 perl(URI)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm | sort -f | uniq -c
1 perl(AnyEvent::Connector) = 0.04
1 perl(AnyEvent::Connector::Proxy::http)
1 perl-AnyEvent-Connector = 0.04-4.fc41
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-AnyEvent-Connector-0.04-4.fc41.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117380297). Ok.
Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building this package.
Resolution: Package APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-AnyEvent-Connector FEDORA-2024-a4418d7909 (perl-AnyEvent-Connector-0.04-4.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a4418d7909 FEDORA-2024-02cd4f5547 (perl-AnyEvent-Connector-0.04-4.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-02cd4f5547 FEDORA-2024-a4418d7909 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a4418d7909 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a4418d7909 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-02cd4f5547 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-02cd4f5547 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-02cd4f5547 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-a4418d7909 (perl-AnyEvent-Connector-0.04-4.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-02cd4f5547 (perl-AnyEvent-Connector-0.04-4.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |