Bug 2254931

Summary:	Review Request: perl-Net-Async-HTTP - Use HTTP with IO::Async
Product:	[Fedora] Fedora	Reporter:	Chris Adams <linux>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-31 01:13:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2254917, 2254928
Bug Blocks:	2254932, 2254933

Description Chris Adams 2023-12-17 23:02:49 UTC

Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP-0.49-1.fc39.src.rpm
Description:
This object class implements an asynchronous HTTP user agent. It sends
requests to servers, returning Future instances to yield responses when
they are received. The object supports multiple concurrent connections to
servers, and allows multiple requests in the pipeline to any one
connection. Normally, only one such object will be needed per program to
support any number of requests.

Fedora Account System Username: cmadams

Comment 1 Chris Adams 2023-12-17 23:03:07 UTC

Note: depends on 
perl-IO-Async-SSL (review BZ 2254917) 
perl-Net-Async-SOCKS (review BZ 2254928)

Comment 2 Chris Adams 2024-01-20 19:36:00 UTC

Bumped release for spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP-0.49-2.fc39.src.rpm

Comment 3 Chris Adams 2024-02-02 03:28:03 UTC

Bumped release for additional spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP-0.49-3.fc39.src.rpm

Comment 4 Chris Adams 2024-03-08 20:01:48 UTC

Bumped release for additional spec file cleanups:
Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-HTTP/perl-Net-Async-HTTP-0.49-4.fc39.src.rpm

Comment 5 Petr Pisar 2024-03-14 13:30:29 UTC

URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing slash from URL.

Source0 archive (SHA-512: 593b32c42e13203f1b569e1d3e8ac50d8c95a7f37ab59881fea3d588b3590b527e5319aa69668924fa1decd892b5a5bfb1f38d370ec74227c9eff46c971d8a80) is original. Ok.
Summary verified from lib/Net/Async/HTTP.pm. Ok.
Description verified from lib/Net/Async/HTTP.pm. Ok.
License verified from Build.PL, LICENSE, lib/Net/Async/HTTP.pm, lib/Net/Async/HTTP/Connection.pm, and lib/Net/Async/HTTP/StallTimer.pm. Ok.
No XS code, noarch BuildArch is Ok.

TOOD: Guard the circular "perl(Net::Async::HTTP::Server)" dependency with %{defined: perl_bootstrap} condition and temporarily "%define perl_boostrap 1" at the beginning of the spec file. In Fedora Perl we strive for always bootstrapable Perl stack.
TODO: Constrain the perl(Net::Async::HTTP::Server)" dependency with ">= 0.06" (t/81cross-https.t:13).

TODO: Constrain "perl(Test::Pod)" dependency with ">= 1.00" (t/99pod.t).

TODO: Unset NET_ASYNC_HTTP_MAXCONNS environment variable in %check section (lib/Net/Async/HTTP.pm:15).

All tests pass. Ok.

$ rpmlint perl-Net-Async-HTTP.spec ../SRPMS/perl-Net-Async-HTTP-0.49-4.fc41.src.rpm ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/doc/perl-Net-Async-HTTP
-rw-r--r--    1 root     root                    13283 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/Changes
-rw-r--r--    1 root     root                    20268 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/README
drwxr-xr-x    2 root     root                        0 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/examples
-rwxr-xr-x    1 root     root                      834 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/examples/GET.pl
-rwxr-xr-x    1 root     root                     3040 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/examples/PUT.pl
-rw-r--r--    1 root     root                     5458 Jun  6  2023 /usr/share/doc/perl-Net-Async-HTTP/examples/parallel-put.pl
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/licenses/perl-Net-Async-HTTP
-rw-r--r--    1 root     root                    18413 Jun  6  2023 /usr/share/licenses/perl-Net-Async-HTTP/LICENSE
-rw-r--r--    1 root     root                     8158 Mar  8 01:00 /usr/share/man/man3/Net::Async::HTTP.3pm.gz
-rw-r--r--    1 root     root                      984 Mar  8 01:00 /usr/share/man/man3/Net::Async::HTTP::Connection.3pm.gz
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP
-rw-r--r--    1 root     root                    41538 Mar  8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP.pm
-rw-r--r--    1 root     root                    18804 Mar  8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP/Connection.pm
-rw-r--r--    1 root     root                      681 Mar  8 01:00 /usr/share/perl5/vendor_perl/Net/Async/HTTP/StallTimer.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(:VERSION) >= 5.14.0
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Future) >= 0.28
      1 perl(Future::Utils) >= 0.16
      1 perl(HTTP::Request)
      1 perl(HTTP::Request::Common)
      1 perl(HTTP::Response)
      1 perl(IO::Async::Loop) >= 0.59
      1 perl(IO::Async::Notifier)
      1 perl(IO::Async::Stream) >= 0.59
      1 perl(IO::Async::Timer::Countdown)
      1 perl(List::Util) >= 1.29
      1 perl(Metrics::Any) >= 0.05
      1 perl(Net::Async::HTTP::Connection)
      1 perl(Net::Async::HTTP::StallTimer)
      1 perl(Scalar::Util)
      1 perl(Socket) >= 2.010
      1 perl(Struct::Dumb) >= 0.07
      1 perl(Time::HiRes)
      1 perl(URI)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --recommends -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Compress::Bzip2)
      1 perl(Compress::Raw::Zlib)
      1 perl(IO::Async::SSL)
      1 perl(Net::Async::SOCKS)
TODO: Constrain "perl(Compress::Raw::Zlib)" Recommends with ">= 2.057"(META.json:32).
TODO: Constrain "perl(Net::Async::SOCKS)" dependency with ">= 0.003" (lib/Net/Async/HTTP.pm:437).
TODO: Constrain "perl(Compress::Bzip2)" Recommends with ">= 2.010" (lib/Net/Async/HTTP.pm:1306).
TODO: Constrain "perl(IO::Async::SSL)" Recommends with ">= 0.12" (lib/Net/Async/HTTP.pm:445).

$ rpm -q --provides -p ../RPMS/noarch/perl-Net-Async-HTTP-0.49-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Net::Async::HTTP) = 0.49
      1 perl(Net::Async::HTTP::Connection) = 0.49
      1 perl(Net::Async::HTTP::StallTimer) = 0.49
      1 perl-Net-Async-HTTP = 0.49-4.fc41
Binary provides are Ok,

The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=114944060). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
The package is APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2024-03-14 16:53:22 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Async-HTTP

Comment 7 Fedora Update System 2024-03-22 12:49:42 UTC

FEDORA-2024-d926483d87 (perl-Net-Async-HTTP-0.49-4.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d926483d87

Comment 8 Fedora Update System 2024-03-23 02:28:56 UTC

FEDORA-2024-d926483d87 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d926483d87 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d926483d87

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-03-31 01:13:17 UTC

FEDORA-2024-d926483d87 (perl-Net-Async-HTTP-0.49-4.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.