Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS-0.003-1.fc39.src.rpm Description: Currently provides a very basic implementation of SOCKS_connect: Fedora Account System Username: cmadams
Note: depends on perl-Protocol-SOCKS (review BZ 2254922)
Bumped release for spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS-0.003-2.fc39.src.rpm
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires perl(IO::Async::Loop) - lib/Net/Async/SOCKS.pm:36 perl(IO::Async::Stream) - lib/Net/Async/SOCKS.pm:37 perl(Protocol::SOCKS::Client) - lib/Net/Async/SOCKS.pm:34 perl(Protocol::SOCKS::Constants) - lib/Net/Async/SOCKS.pm:35 TODO: Remove perl(Test::Refcount), it is not used in code $ rpm -qp --requires perl-Net-Async-SOCKS-0.003-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(IO::Async::Loop) 1 perl(IO::Async::Stream) 1 perl-libs 1 perl(Protocol::SOCKS::Client) 1 perl(Protocol::SOCKS::Constants) 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Net-Async-SOCKS-0.003-2.fc40.noarch.rpm | sort | uniq -c 1 perl(Net::Async::SOCKS) = 0.003 1 perl-Net-Async-SOCKS = 0.003-2.fc40 Binary provides are Ok. $ rpmlint ./perl-Net-Async-SOCKS* ================================= rpmlint session starts ========================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 perl-Net-Async-SOCKS.noarch: W: incoherent-version-in-changelog 0.04-2 ['0.003-2.fc40', '0.003-2'] === 2 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ========= FIX: Update different version in changelog TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item. Resolution: Approved
Bumped release for additional spec file cleanups: Spec URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS.spec SRPM URL: https://cmadams.fedorapeople.org/perl-Net-Async-SOCKS/perl-Net-Async-SOCKS-0.003-3.fc39.src.rpm
The update looks good. The review was already approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Async-SOCKS
FEDORA-2024-0dfd10281a (perl-Net-Async-SOCKS-0.003-3.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dfd10281a
Thanks for the review! I focused on the FIX bits and managed to not notice the Approved line. :)
FEDORA-2024-0dfd10281a has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0dfd10281a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0dfd10281a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-0dfd10281a (perl-Net-Async-SOCKS-0.003-3.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.