Bug 2255010

Summary:	F40FailsToInstall: python3-impacket
Product:	[Fedora] Fedora	Reporter:	Fedora Fails To Install <fti-bugs>
Component:	python-impacket	Assignee:	Michal Ambroz <rebus>
Status:	CLOSED WORKSFORME	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mail, mhroncok, paul, rebus
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-01-24 16:43:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2259466
Bug Blocks:	2231790

Description Fedora Fails To Install 2023-12-18 13:42:45 UTC

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

Your package (python-impacket) Fails To Install in Fedora 40:

can't install python3-impacket:
  - nothing provides python3.12dist(dsinternals) needed by python3-impacket-0.11.0-1.fc40.noarch
  
If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.


If you don't react accordingly to the policy for FTBFS/FTI bugs (https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/), your package may be orphaned in 8+ weeks.


P.S. The data was generated solely from koji buildroot, so it might be newer than the latest compose or the content on mirrors. To reproduce, use the koji/local repo only, e.g. in mock:

    $ mock -r fedora-40-x86_64 --config-opts mirrored=False install python3-impacket


P.P.S. If this bug has been reported in the middle of upgrading multiple dependent packages, please consider using side tags: https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/#updating-inter-dependent-packages

Thanks!

Comment 1 Paul Howarth 2024-01-19 17:44:14 UTC

dsinternals is used by impacket/examples/ntlmrelayx/attacks/ldapattack.py

Perhaps dsinternals could be added to the __requires_exclude regexp and "Recommends: python%{python3_pkgversion}-dsinternals" added instead, similarly to some of the other dependencies?

Note that python3-impacket is a build dependency of curl and this failure to install will prevent curl being rebuilt successfully in the Fedora 40 mass rebuild, which started today.

Comment 2 Miro Hrončok 2024-01-19 22:04:44 UTC

If you are to exclude the dependency, please patch upstream metadata, don't %__requires_exclude it. Some Python tooling might refuse to work and report the dependency missing if it is unmet but part of the egg-info/dist-info requirements.

----

Also note that Recommending packages that do not exist in Fedora is not allowed: https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/

"""
As with regular dependencies, weak dependencies MUST be satisfiable within the official Fedora repositories.
"""

(Last time I checked, this was also a legal requirement, not just packaging guidelines. But that was years ago.)

Comment 3 Michal Ambroz 2024-01-24 03:13:56 UTC

going with the quick exclude hack for now to not stale the curl rebuild (it is using impacket as temporary smb server during tests).
ldapdomaindump package already available, dsinternals in review

Comment 4 Fedora Fails To Install 2024-01-24 16:43:48 UTC

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 40.

Thanks for taking care of it!