Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec SRPM URL: https://rebus.fedorapeople.org/python-dsinternals-1.2.4-1.fc39.src.rpm Description: Directory Services Internals Library. Python native library containing necessary classes, functions and structures to interact with Windows Active Directory. Installation python3 -m pip install dsinternals ContributingPull requests are welcome. Feel free to open an issue if... Fedora Account System Username: rebus
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112144545
Copr build: https://copr.fedorainfracloud.org/coprs/build/6937237 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259466-python-dsinternals/fedora-rawhide-x86_64/06937237-python-dsinternals/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello Michal, Is there a reason why this package doesn't use the %pyproject_buildrequires macro to build the python requirements (Ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros)?
Hello Steve, I would love to use the pyproject macros, but I plan to use the package acros the EPELs as well and pyproject is not on epel7 and having some issues on rhel8. I would preffer to have one spec for all supported platforms.
Would it then be possible to logicgate the sections, i.e. have el7 use the current version, but have el8+ and fedora use the new macros?
Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec SRPM URL: https://rebus.fedorapeople.org/python-dsinternals-1.2.4-2.fc39.src.rpm Hello, here the attempt to run the %generate_buildrequires/%pyproject_buildrequires if available https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6942085/ It is still failing on epel8 even it should not. Spec is requesting python%{python3_pkgversion}-setuptools, which on epel3 gets resolved as python3-setuptools, but then the build complains about missing setuptools ... probably module for python 3.11 I am thinking of swithcing back to legacy py3_build/py3_install ... that one would work even on rhel7 :(...
Created attachment 2010000 [details] The .spec file difference from Copr build 6937237 to 6944190
Copr build: https://copr.fedorainfracloud.org/coprs/build/6944190 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259466-python-dsinternals/fedora-rawhide-x86_64/06944190-python-dsinternals/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Michal Ambroz from comment #6) > Spec URL: https://rebus.fedorapeople.org/python-dsinternals.spec > SRPM URL: > https://rebus.fedorapeople.org/python-dsinternals-1.2.4-2.fc39.src.rpm > > Hello, > here the attempt to run the %generate_buildrequires/%pyproject_buildrequires > if available > https://copr.fedorainfracloud.org/coprs/rebus/infosec/build/6942085/ > > It is still failing on epel8 even it should not. > Spec is requesting python%{python3_pkgversion}-setuptools, which on epel3 > gets resolved as python3-setuptools, but then the build complains about > missing setuptools ... probably module for python 3.11 > > I am thinking of swithcing back to legacy py3_build/py3_install ... that one > would work even on rhel7 :(... The el7 build seems to be failing because of ``` Error: No Package found for pyproject-rpm-macros ``` As far as el8 goes, yeah I would probably just revert back to the old python macros for that specific version, I'm guessing your haunch is right here. I'm not sure what Fedora's guidelines are as far as using a mixed legacy/pywheel macro set in a spec meant to be used in older versions of epel, to be 100% honest here.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
yep, still interested