Bug 2255654
| Summary: | Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yaakov Selkowitz <yselkowi> |
| Component: | Package Review | Assignee: | Pavel Solovev <daron439> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | daron439, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | daron439:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-01-17 01:05:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Yaakov Selkowitz
2023-12-22 18:57:56 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784938 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255654-golang-github-1player-host-spawn/fedora-rawhide-x86_64/06784938-golang-github-1player-host-spawn/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. If you only need the binary (not the library) you can regenerate with go2rpm github.com/1player/host-spawn --name host-spawn, remove %gopkg, %gopkginstall and %gopkgfiles.
> %{_bindir}/*
%{_bindir}/host-spawn
Spec URL: https://yselkowitz.fedorapeople.org/host-spawn.spec SRPM URL: https://yselkowitz.fedorapeople.org/host-spawn-1.5.1-1.fc40.src.rpm Description: Run commands on your host from inside your toolbox or flatpak sandbox. (Needed for qmlkonsole flatpak.) Fedora Account System Username: yselkowitz Copr build: https://copr.fedorainfracloud.org/coprs/build/6873490 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255654-host-spawn/fedora-rawhide-x86_64/06873490-host-spawn/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [-] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
Just want to sleep :)
Could you please review https://bugzilla.redhat.com/show_bug.cgi?id=2256995 ?
The Pagure repository was created at https://src.fedoraproject.org/rpms/host-spawn FEDORA-2024-8cd1379ee3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3 FEDORA-2024-3b94820c3b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8cd1379ee3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3b94820c3b \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |