Bug 2255654 - Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox
Summary: Review Request: host-spawn - Run commands on your host from inside your toolb...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Pavel Solovev
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-22 18:57 UTC by Yaakov Selkowitz
Modified: 2024-01-17 01:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-17 01:05:22 UTC
Type: ---
Embargoed:
daron439: fedora-review+


Attachments (Terms of Use)

Description Yaakov Selkowitz 2023-12-22 18:57:56 UTC
Spec URL: https://yselkowitz.fedorapeople.org/golang-github-1player-host-spawn.spec
SRPM URL: https://yselkowitz.fedorapeople.org/golang-github-1player-host-spawn-1.5.1-1.fc40.src.rpm
Description: Run commands on your host from inside your toolbox or flatpak sandbox. (Needed for qmlkonsole flatpak.)
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2023-12-23 04:36:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6784938
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255654-golang-github-1player-host-spawn/fedora-rawhide-x86_64/06784938-golang-github-1player-host-spawn/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Pavel Solovev 2024-01-08 21:42:25 UTC
If you only need the binary (not the library) you can regenerate with go2rpm github.com/1player/host-spawn --name host-spawn, remove %gopkg, %gopkginstall and %gopkgfiles.

> %{_bindir}/*
%{_bindir}/host-spawn

Comment 3 Yaakov Selkowitz 2024-01-08 22:36:09 UTC
Spec URL: https://yselkowitz.fedorapeople.org/host-spawn.spec
SRPM URL: https://yselkowitz.fedorapeople.org/host-spawn-1.5.1-1.fc40.src.rpm
Description: Run commands on your host from inside your toolbox or flatpak sandbox. (Needed for qmlkonsole flatpak.)
Fedora Account System Username: yselkowitz

Comment 4 Fedora Review Service 2024-01-08 22:41:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6873490
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255654-host-spawn/fedora-rawhide-x86_64/06873490-host-spawn/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Pavel Solovev 2024-01-08 23:02:19 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [-] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 6 Pavel Solovev 2024-01-08 23:05:58 UTC
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
Just want to sleep :)

Could you please review https://bugzilla.redhat.com/show_bug.cgi?id=2256995 ?

Comment 7 Fedora Admin user for bugzilla script actions 2024-01-08 23:41:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/host-spawn

Comment 8 Fedora Update System 2024-01-09 00:01:55 UTC
FEDORA-2024-8cd1379ee3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3

Comment 9 Fedora Update System 2024-01-09 00:02:24 UTC
FEDORA-2024-3b94820c3b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b

Comment 10 Fedora Update System 2024-01-09 01:20:45 UTC
FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8cd1379ee3 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-09 01:39:26 UTC
FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3b94820c3b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-17 01:05:22 UTC
FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-01-17 01:37:07 UTC
FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.