Bug 2256305
| Summary: | Review Request: golang-github-aphistic-golf - Client library written in Go for sending messages to Graylog Extended Log Format (GELF) servers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | arthur, mikel, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2256303 | ||
|
Description
W. Michael Petullo
2023-12-31 01:32:01 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-aphistic-golf.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aphistic-golf-0-0.1.20231231git02c07f1.fc39.src.rpm Rebuild with go2rpm 1.10.0. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840029 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256305-golang-github-aphistic-golf/fedora-rawhide-x86_64/06840029-golang-github-aphistic-golf/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840056 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256305-golang-github-aphistic-golf/fedora-rawhide-x86_64/06840056-golang-github-aphistic-golf/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Is this required for hugo? I can't see it required in the code, nor your copr build. I looked into the tests and it looks like they were added in this commit: https://github.com/aphistic/golf/commit/eb9324 . Nothing meaningful changed since then (some CI fixes), so I suggest packaging the commit before the switch to sweet: https://github.com/aphistic/golf/commit/b8be15 . log_test.go and log_default_test.go still fail, but you can easily fix them or just disable them. Spec URL: https://www.flyn.org/SRPMS/golang-github-aphistic-golf.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aphistic-golf-0-0.1.20240201gitb8be15e.fc39.src.rpm Package older version to avoid golang-github-aphistic-sweet, which we cannot package. See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2256306 for why. Thank you, Arthur, for the suggestion! > Is this required for hugo? I can't see it required in the code, nor your > copr build. Yes. The dependency is hugo -> github.com/bep/logg -> github.com/apex/log -> github.com/aphistic/golf. Copr build: https://copr.fedorainfracloud.org/coprs/build/6980580 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256305-golang-github-aphistic-golf/fedora-rawhide-x86_64/06980580-golang-github-aphistic-golf/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks for the update. Some issues I found: - Enable tests (remove `-d .`) You will have to remove/fix the `log_default_test.go` and `log_test.go` files as these can't be compiled. - Summary is too long Otherwise looking good! This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. |