Bug 2256303 - Review Request: golang-github-apex-log - Structured logging package for Go
Summary: Review Request: golang-github-apex-log - Structured logging package for Go
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Arthur Bols
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2256305 2256304 2256307 2256313 2256316
Blocks: 2256315
TreeView+ depends on / blocked
 
Reported: 2023-12-31 01:29 UTC by W. Michael Petullo
Modified: 2024-02-01 23:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
arthur: fedora-review?


Attachments (Terms of Use)

Description W. Michael Petullo 2023-12-31 01:29:01 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-apex-log.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-apex-log-1.9.0-1.fc39.src.rpm
Description: Structured logging package for Go
Fedora Account System Username: mikep

This was generated using go2rpm and is required for the latest release of Hugo. See COPR builds at https://copr.fedorainfracloud.org/coprs/mikep/golang/builds/.

Comment 1 W. Michael Petullo 2023-12-31 05:50:26 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-apex-log.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-apex-log-1.9.0-1.fc39~bootstrap.src.rpm

Use bootstrap to address circular dependencies.

Comment 3 Fedora Review Service 2023-12-31 19:14:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840027
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256303-golang-github-apex-log/srpm-builds/06840027/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2023-12-31 19:17:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840040
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256303-golang-github-apex-log/fedora-rawhide-x86_64/06840040-golang-github-apex-log/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2023-12-31 19:19:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6840058
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256303-golang-github-apex-log/fedora-rawhide-x86_64/06840058-golang-github-apex-log/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 W. Michael Petullo 2024-01-06 21:36:19 UTC
Unretire request: https://pagure.io/releng/issue/11881

Comment 7 Arthur Bols 2024-02-01 18:01:10 UTC
Package Review
==============

Package was generated by go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======


Checks:
=======
[x]: Spec file is sane.
[x]: Latest version is packaged.
[x]: License is correct and license file is included.
[x]: %check is present and all tests pass.
[x]: Package builds in mock.
[x]: Package installs properly.
[x]: rpmlint shows no relevant errors.
     There are many warnings about duplicate files, but these seem to be needed for testing, so can be ignored.
[x]: Package does not generate any conflict.
[x]: Package complies to the Packaging Guidelines


Package APPROVED. Please fix the issue above before import.

Post import tasks:
- Add @go-sig with commit or admin access to the package
- If possible, add your package to release-monitoring.org

Comment 8 Arthur Bols 2024-02-01 18:01:57 UTC
Sorry for that comment, clipboard error... Just wanted to update the depends.

Package is NOT YET APPROVED!


Note You need to log in before you can comment on or make changes to this bug.