Bug 2256307
| Summary: | Review Request: golang-github-aybabtme-rgbterm - RGB colors for your terminal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mikel, package-review | ||||
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-01-16 01:26:00 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2256303 | ||||||
| Attachments: |
|
||||||
|
Description
W. Michael Petullo
2023-12-31 01:34:04 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm-0-0.1.20231231gitcc83f3b.fc39.src.rpm Rebuild with go2rpm 1.10.0. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840030 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256307-golang-github-aybabtme-rgbterm/fedora-rawhide-x86_64/06840030-golang-github-aybabtme-rgbterm/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840054 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256307-golang-github-aybabtme-rgbterm/fedora-rawhide-x86_64/06840054-golang-github-aybabtme-rgbterm/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Unretire request: https://pagure.io/releng/issue/11878 Spec is correct but there are a couple of issues: > License: MIT Is not correct. Some functions are under BSD-2-Clause: https://github.com/aybabtme/rgbterm/blob/master/LICENSE#L23 It should be License: BSD-2-Clause AND MIT > RPM build warnings: > File listed twice: /usr/share/doc/golang-github-aybabtme-rgbterm-devel/README.md > File listed twice: /usr/share/licenses/golang-github-aybabtme-rgbterm-devel/LICENSE You need to rename these files to avoid this issue. You can check the following spec as example: https://src.fedoraproject.org/rpms/golang-github-prometheus-client/blob/rawhide/f/golang-github-prometheus-client.spec#_48 Spec URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-aybabtme-rgbterm-0-0.1.20231231gitcc83f3b.fc39.src.rpm - Add second license - Rename duplicate LICENSE file and README.md Created attachment 2007797 [details]
The .spec file difference from Copr build 6840054 to 6872106
Copr build: https://copr.fedorainfracloud.org/coprs/build/6872106 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256307-golang-github-aybabtme-rgbterm/fedora-rawhide-x86_64/06872106-golang-github-aybabtme-rgbterm/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'BSD-2-Clause and MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-aybabtme-rgbterm Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. Unretire request: https://pagure.io/releng/issue/11878 |