Bug 2256316
| Summary: | Review Request: golang-github-tj-spin - Terminal spinner package for Golang | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> | ||||
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mikel, package-review | ||||
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-01-13 00:03:11 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2256303 | ||||||
| Attachments: |
|
||||||
|
Description
W. Michael Petullo
2023-12-31 01:43:35 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-tj-spin.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-tj-spin-1.1.0-1.fc39.src.rpm Rebuild with go2rpm 1.10.0. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840045 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256316-golang-github-tj-spin/fedora-rawhide-x86_64/06840045-golang-github-tj-spin/fedora-review/review.txt Found issues: - Not a valid SPDX expression '# FIXME'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-tj-spin Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840039 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256316-golang-github-tj-spin/fedora-rawhide-x86_64/06840039-golang-github-tj-spin/fedora-review/review.txt Found issues: - Not a valid SPDX expression '# FIXME'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-tj-spin Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://www.flyn.org/SRPMS/golang-github-tj-spin.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-tj-spin-1.1.0-1.fc39.src.rpm Fix license. Created attachment 2006746 [details]
The .spec file difference from Copr build 6840045 to 6843485
Copr build: https://copr.fedorainfracloud.org/coprs/build/6843485 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256316-golang-github-tj-spin/fedora-rawhide-x86_64/06843485-golang-github-tj-spin/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-tj-spin Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The `example` from godocs could be removed. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. |