Bug 225647
| Summary: | Merge Review: compat-db | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, jnovy, jochen |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-07 15:19:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 816124 | ||
| Bug Blocks: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 17:50:32 UTC
I would suggest, that you should splitt this package into three main packages. One for each version of the BerkleyDb which should be supported. Good:
- rpmlint checks return:
Lots of unversion-explicit provides and obsolete-not-provided which should be fixed/dropped etc.
compat-db.spec:209: W: macro-in-comment %{_libdir}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.
Trivial fix.
compat-db45.x86_64: E: devel-dependency compat-db-headers
Your package has a dependency on a devel package but it's not a devel package
itself.
Fix, if possible.
compat-db45.x86_64: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
Ignore, I suspect.
Lots of no-man-page-for-binary. Ignore.
Lots of rpath warning. Fix if at all possible.
- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package N/A
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r N/A
The requires situation is unorthodox, but logical given the nature of the package.
Really looks like it's just the rpmlint stuff, let me know if you'd like me to commit any of this.
Ping? I'll commit the macro fixes if that's ok? (In reply to comment #3) > Ping? I'll commit the macro fixes if that's ok? Jon, thanks for looking into it. Maybe better is to review libdb4: https://bugzilla.redhat.com/show_bug.cgi?id=816124 so that we can get rid of both compat-db and db4 in rawhide. Could you please have look at it? Indeed, good idea. Retired, APPROVED, closed. |