Bug 2256508

Summary:	Review Request: rust-git-conventional - Parser library for the Conventional Commit specification
Product:	[Fedora] Fedora	Reporter:	Onuralp Sezer <thunderbirdtr>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	POST ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://crates.io/crates/git-conventional
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Onuralp Sezer 2024-01-02 19:39:38 UTC

Spec URL: https://thunderbirdtr.fedorapeople.org/rust-git-conventional/rust-git-conventional.spec
SRPM URL: https://thunderbirdtr.fedorapeople.org/rust-git-conventional/rust-git-conventional-0.12.4-1.fc40.src.rpm
Description: Parser library for the Conventional Commit specification
Fedora Account System Username: thunderbirdtr

Comment 1 Fedora Review Service 2024-01-02 19:43:22 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6850112
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256508-rust-git-conventional/fedora-rawhide-x86_64/06850112-rust-git-conventional/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-09 22:08:53 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please take care when importing the package:
Use the un-modified spec file, not the one from the SRPM that has already been processed by rpmautospec.