Bug 2256508 - Review Request: rust-git-conventional - Parser library for the Conventional Commit specification
Summary: Review Request: rust-git-conventional - Parser library for the Conventional C...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/git-conventi...
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2024-01-02 19:39 UTC by Onuralp Sezer
Modified: 2025-04-29 00:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-04-29 00:45:26 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Onuralp Sezer 2024-01-02 19:39:38 UTC
Spec URL: https://thunderbirdtr.fedorapeople.org/rust-git-conventional/rust-git-conventional.spec
SRPM URL: https://thunderbirdtr.fedorapeople.org/rust-git-conventional/rust-git-conventional-0.12.4-1.fc40.src.rpm
Description: Parser library for the Conventional Commit specification
Fedora Account System Username: thunderbirdtr

Comment 1 Fedora Review Service 2024-01-02 19:43:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6850112
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256508-rust-git-conventional/fedora-rawhide-x86_64/06850112-rust-git-conventional/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-09 22:08:53 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please take care when importing the package:
Use the un-modified spec file, not the one from the SRPM that has already been processed by rpmautospec.

Comment 3 Fabio Valentini 2024-07-05 16:48:30 UTC
Looks like this was never imported?

Comment 4 Onuralp Sezer 2024-07-05 17:00:37 UTC
I will look when back to my Fedora computer today hopefully, sorry delay.

Comment 5 Fabio Valentini 2024-10-13 20:16:52 UTC
Not hopeful enough, apparently :D

Comment 6 Fabio Valentini 2025-03-29 22:53:05 UTC
Still not enough hope ...

Comment 7 Package Review 2025-04-29 00:45:26 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.