Bug 2257189

Three minor issues:

- Please document the patch (like adding a line above "Patch: ..." with "# bump serial_test dev-dependency from 0.5 to 2"
- Can you submit the patch to update this dependency as a PR to upstream?
- Please exclude some files that don't make sense in the packaging - like coverage.sh and coverage-style.css.patch. This might also make sense as a PR for upstream.

Other than that, package looks good.

(In reply to Fabio Valentini from comment #1)
> Three minor issues:
> 
> - Please document the patch (like adding a line above "Patch: ..." with "#
> bump serial_test dev-dependency from 0.5 to 2"

it has this right now
# * bump serial_test to 2

I can make it more explicit

> - Can you submit the patch to update this dependency as a PR to upstream?

Can do. In this case I should probably make upstream accept a range from 0.5 to 2, right, since obviously it still works with 0.5 too

> - Please exclude some files that don't make sense in the packaging - like
> coverage.sh and coverage-style.css.patch. This might also make sense as a PR
> for upstream.
> 

Will do too, thanks

(In reply to Michel Lind from comment #2)
> (In reply to Fabio Valentini from comment #1)
> > Three minor issues:
> > 
> > - Please document the patch (like adding a line above "Patch: ..." with "#
> > bump serial_test dev-dependency from 0.5 to 2"
> 
> it has this right now
> # * bump serial_test to 2
> 
> I can make it more explicit

Ah, that line is only in the linked spec, but not in the spec in the linked SRPM.
So I guess you forgot to re-run rpmbuild -bs after adding it.
The line you have there is fine, no need to be more verbose.

> > - Can you submit the patch to update this dependency as a PR to upstream?
> 
> Can do. In this case I should probably make upstream accept a range from 0.5
> to 2, right, since obviously it still works with 0.5 too

That would be perfect. Something like ">=0.5,<3".

> > - Please exclude some files that don't make sense in the packaging - like
> > coverage.sh and coverage-style.css.patch. This might also make sense as a PR
> > for upstream.
> > 
> 
> Will do too, thanks

:+1:

(In reply to Fabio Valentini from comment #3)
> (In reply to Michel Lind from comment #2)
> > (In reply to Fabio Valentini from comment #1)
> > > Three minor issues:
> > > 
> > > - Please document the patch (like adding a line above "Patch: ..." with "#
> > > bump serial_test dev-dependency from 0.5 to 2"
> > 
> > it has this right now
> > # * bump serial_test to 2
> > 
> > I can make it more explicit
> 
> Ah, that line is only in the linked spec, but not in the spec in the linked
> SRPM.
> So I guess you forgot to re-run rpmbuild -bs after adding it.
> The line you have there is fine, no need to be more verbose.
> 
> > > - Can you submit the patch to update this dependency as a PR to upstream?
> > 
> > Can do. In this case I should probably make upstream accept a range from 0.5
> > to 2, right, since obviously it still works with 0.5 too
> 
> That would be perfect. Something like ">=0.5,<3".
> 
> > > - Please exclude some files that don't make sense in the packaging - like
> > > coverage.sh and coverage-style.css.patch. This might also make sense as a PR
> > > for upstream.
> > > 
> > 
> > Will do too, thanks
> 
> :+1:

sent PRs upstream for both (see updated spec for links to PRs)

Spec URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton.spec
SRPM URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton-0.1.2-1.fc38.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6872357
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257189-rust-reference-counted-singleton/fedora-rawhide-x86_64/06872357-rust-reference-counted-singleton/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

You would not have needed to exclude ".gitignore", any hidden files should already be excluded by %cargo_install automatically, but it doesn't hurt.

Ah, I'll keep it for now since it doesn't matter anyway, and upstream will hopefully accept the PR soon with or without changes. thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reference-counted-singleton

FEDORA-2024-cb524aedca has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-cb524aedca

FEDORA-2024-3be808720f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3be808720f

FEDORA-2024-cb524aedca has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-cb524aedca \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-cb524aedca

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-3be808720f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3be808720f \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3be808720f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-3be808720f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-cb524aedca has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.