Spec URL: https://salimma.fedorapeople.org/rust-selinux.spec SRPM URL: https://salimma.fedorapeople.org/rust-selinux-0.4.2-1.fc38.src.rpm Description: Flexible Mandatory Access Control for Linux. Fedora Account System Username: salimma
Three minor issues: 1. Not sure how this is possible, but the hash for the license file in your SRPM does not match the hash for the license file downloaded from upstream. You might want to reference a specific commit instead of "whatever is on top of master right now" to prevent this from happening. 2. Why is there a dependency on libacl-devel in this package? If it's a test-only dependency, it should not be added as Requires: libacl-devel in the -devel subpackage. If it's a dependency of the selinux bindings, it should be added in the package for the selinux-sys crate instead. Since I cannot find any references to the string "acl" in the sources for this package, I assume the latter is the case. 3. Upstream has released a new version (v0.4.3), please update if possible.
(In reply to Fabio Valentini from comment #1) > Three minor issues: > > 1. Not sure how this is possible, but the hash for the license file in your > SRPM does not match the hash for the license file downloaded from upstream. > You might want to reference a specific commit instead of "whatever is on top > of master right now" to prevent this from happening. > yeah, looks like upstream bumped the year in the copyright in https://github.com/koutheir/selinux/commit/2912ed0507b645988422fc401a19ebb2248b5621 > 2. Why is there a dependency on libacl-devel in this package? Uh, turns out I copied rust2rpm.toml from rust-exacl which of course requires libacl > 3. Upstream has released a new version (v0.4.3), please update if possible. Updated. This includes the license text so we're good there. I have to lower the serial_test dependency which is bumped in 0.4.3 to v3 (we only have v2), there are some breaking changes that it looks like upstream is not using yet. Spec URL: https://salimma.fedorapeople.org/rust-selinux.spec SRPM URL: https://salimma.fedorapeople.org/rust-selinux-0.4.3-1.fc38.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923974 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257190-rust-selinux/fedora-rawhide-x86_64/06923974-rust-selinux/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-selinux
FEDORA-2024-4cde412338 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4cde412338
FEDORA-2024-4cde412338 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-8c6f0c3ac7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8c6f0c3ac7
FEDORA-2024-25180718b5 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-25180718b5
FEDORA-2024-8c6f0c3ac7 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8c6f0c3ac7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8c6f0c3ac7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-25180718b5 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-25180718b5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-25180718b5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-8c6f0c3ac7 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-25180718b5 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.