Bug 225720

Summary:	Merge Review: eject
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	Ruben Kerkhof <ruben>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kdudka, ruben, than
Target Milestone:	---	Flags:	ruben: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.1.5-17.fc13	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-09 17:09:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 18:32:03 UTC

Fedora Merge Review: eject

http://cvs.fedora.redhat.com/viewcvs/devel/eject/
Initial Owner: than

Comment 1 Ruben Kerkhof 2007-02-03 18:24:56 UTC

* RPM name is OK
* Source eject-2.1.5.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)

Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)

Notes:
* Please use {?dist} in Release tag

Comment 2 Kamil Dudka 2009-11-25 14:37:17 UTC

Thanks for review! I've just committed the changes and built it as eject-2.1.5-16.fc13.

Comment 3 Ruben Kerkhof 2009-11-25 21:37:19 UTC

Wow, it almost took 3 years ;-)

I'll have another look at the newer version soon.

Comment 4 Kamil Dudka 2009-11-25 21:56:28 UTC

(In reply to comment #3)
> Wow, it almost took 3 years ;-)

Glad to see the review is not actually dead! Sorry for the delay, I am new to eject, so that I somehow missed the bug before.

I've spotted yet another issue with eject. Its upstream seems to be dead and the source URL is no longer valid for 2.1.5. Moreover I didn't find any other mirror providing this version of eject. I don't know what's the proper way to deal with it. Any idea?

> I'll have another look at the newer version soon.

Thanks in advance!

Comment 5 Ruben Kerkhof 2009-11-25 22:11:58 UTC

I guess that just made Fedora the upstream :-)

If you want you can ask for a project on fedorahosted:
https://fedorahosted.org/web/new

Comment 6 Kamil Dudka 2009-11-25 23:11:03 UTC

A long term plan is to include its sources to linux-util-ng project. As a side effect we can share part of its code with other utilities (e.g. mount).

Comment 7 Ruben Kerkhof 2010-01-31 14:31:32 UTC

Can you please fix the rpmlint warnings?

eject.x86_64: W: no-dependency-on usermode
eject.x86_64: W: non-conffile-in-etc /etc/security/console.apps/eject
eject.x86_64: W: non-conffile-in-etc /etc/pam.d/eject

Comment 8 Kamil Dudka 2010-02-02 11:41:42 UTC

Thank you for the review!  All of them should be fixed in eject-2.1.5-17.fc13.

Comment 9 Ruben Kerkhof 2010-02-09 17:09:42 UTC

Thanks, I have no further comments, so this package is approved.