Bug 225720 - Merge Review: eject
Merge Review: eject
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ruben Kerkhof
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 13:32 EST by Nobody's working on this, feel free to take it
Modified: 2010-02-09 18:19 EST (History)
3 users (show)

See Also:
Fixed In Version: 2.1.5-17.fc13
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-02-09 12:09:42 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 13:32:03 EST
Fedora Merge Review: eject

Initial Owner: than@redhat.com
Comment 1 Ruben Kerkhof 2007-02-03 13:24:56 EST
* RPM name is OK
* Source eject-2.1.5.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)

* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)

* Please use {?dist} in Release tag
Comment 2 Kamil Dudka 2009-11-25 09:37:17 EST
Thanks for review! I've just committed the changes and built it as eject-2.1.5-16.fc13.
Comment 3 Ruben Kerkhof 2009-11-25 16:37:19 EST
Wow, it almost took 3 years ;-)

I'll have another look at the newer version soon.
Comment 4 Kamil Dudka 2009-11-25 16:56:28 EST
(In reply to comment #3)
> Wow, it almost took 3 years ;-)

Glad to see the review is not actually dead! Sorry for the delay, I am new to eject, so that I somehow missed the bug before.

I've spotted yet another issue with eject. Its upstream seems to be dead and the source URL is no longer valid for 2.1.5. Moreover I didn't find any other mirror providing this version of eject. I don't know what's the proper way to deal with it. Any idea?

> I'll have another look at the newer version soon.

Thanks in advance!
Comment 5 Ruben Kerkhof 2009-11-25 17:11:58 EST
I guess that just made Fedora the upstream :-)

If you want you can ask for a project on fedorahosted:
Comment 6 Kamil Dudka 2009-11-25 18:11:03 EST
A long term plan is to include its sources to linux-util-ng project. As a side effect we can share part of its code with other utilities (e.g. mount).
Comment 7 Ruben Kerkhof 2010-01-31 09:31:32 EST
Can you please fix the rpmlint warnings?

eject.x86_64: W: no-dependency-on usermode
eject.x86_64: W: non-conffile-in-etc /etc/security/console.apps/eject
eject.x86_64: W: non-conffile-in-etc /etc/pam.d/eject
Comment 8 Kamil Dudka 2010-02-02 06:41:42 EST
Thank you for the review!  All of them should be fixed in eject-2.1.5-17.fc13.
Comment 9 Ruben Kerkhof 2010-02-09 12:09:42 EST
Thanks, I have no further comments, so this package is approved.

Note You need to log in before you can comment on or make changes to this bug.