Fedora Merge Review: eject http://cvs.fedora.redhat.com/viewcvs/devel/eject/ Initial Owner: than
* RPM name is OK * Source eject-2.1.5.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) Minor: * Duplicate BuildRequires: autoconf (by automake), automake (by libtool) Notes: * Please use {?dist} in Release tag
Thanks for review! I've just committed the changes and built it as eject-2.1.5-16.fc13.
Wow, it almost took 3 years ;-) I'll have another look at the newer version soon.
(In reply to comment #3) > Wow, it almost took 3 years ;-) Glad to see the review is not actually dead! Sorry for the delay, I am new to eject, so that I somehow missed the bug before. I've spotted yet another issue with eject. Its upstream seems to be dead and the source URL is no longer valid for 2.1.5. Moreover I didn't find any other mirror providing this version of eject. I don't know what's the proper way to deal with it. Any idea? > I'll have another look at the newer version soon. Thanks in advance!
I guess that just made Fedora the upstream :-) If you want you can ask for a project on fedorahosted: https://fedorahosted.org/web/new
A long term plan is to include its sources to linux-util-ng project. As a side effect we can share part of its code with other utilities (e.g. mount).
Can you please fix the rpmlint warnings? eject.x86_64: W: no-dependency-on usermode eject.x86_64: W: non-conffile-in-etc /etc/security/console.apps/eject eject.x86_64: W: non-conffile-in-etc /etc/pam.d/eject
Thank you for the review! All of them should be fixed in eject-2.1.5-17.fc13.
Thanks, I have no further comments, so this package is approved.