Bug 2257272
| Summary: | Review Request: golang-github-bep-clocks - A Golang clock that allows you to set the start time | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | mikel:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-02-02 14:37:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2209669 | ||
|
Description
W. Michael Petullo
2024-01-08 14:48:51 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6872124 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257272-golang-github-bep-clocks/fedora-rawhide-x86_64/06872124-golang-github-bep-clocks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > Obsoletes: golang-github-bep-clock
Change for the following before pushing:
# Remove in F42:
%global godevelheader %{expand:
Obsoletes: golang-github-bep-clock-devel < 0.3.0-4
}
Other than that, package is correct.
I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
https://pagure.io/releng/fedora-scm-requests/issue/60155 The repository creation seems to have failed in Pagure. For reference, see https://pagure.io/fedora-infrastructure/issue/11750 for the ticket about the failed new repository request. FEDORA-2024-c0a786f5f9 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c0a786f5f9 FEDORA-2024-c0a786f5f9 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |