Bug 2257272 - Review Request: golang-github-bep-clocks - A Golang clock that allows you to set the start time
Summary: Review Request: golang-github-bep-clocks - A Golang clock that allows you to ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2209669
TreeView+ depends on / blocked
 
Reported: 2024-01-08 14:48 UTC by W. Michael Petullo
Modified: 2024-02-02 14:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-02 14:37:21 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2024-01-08 14:48:51 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-bep-clocks.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-bep-clocks-0.5.0-1.fc39.src.rpm
Description: A Golang clock that allows you to set the start time
Fedora Account System Username: mikep

This will obsolete golang-github-bep-clock, as the goipath has changed from clock to clocks.

Comment 1 Fedora Review Service 2024-01-08 14:53:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6872124
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257272-golang-github-bep-clocks/fedora-rawhide-x86_64/06872124-golang-github-bep-clocks/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2024-01-08 16:19:43 UTC
> Obsoletes: golang-github-bep-clock

Change for the following before pushing:

# Remove in F42:
%global godevelheader %{expand:
Obsoletes:      golang-github-bep-clock-devel < 0.3.0-4
}

Other than that, package is correct.

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 3 W. Michael Petullo 2024-02-01 21:05:27 UTC
https://pagure.io/releng/fedora-scm-requests/issue/60155

The repository creation seems to have failed in Pagure.

Comment 4 W. Michael Petullo 2024-02-01 21:11:33 UTC
For reference, see https://pagure.io/fedora-infrastructure/issue/11750 for the ticket about the failed new repository request.

Comment 5 Fedora Update System 2024-02-02 14:37:11 UTC
FEDORA-2024-c0a786f5f9 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c0a786f5f9

Comment 6 Fedora Update System 2024-02-02 14:37:21 UTC
FEDORA-2024-c0a786f5f9 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.