Bug 2257490

Summary: Review Request: rust-uu_ls - ls ~ (uutils) display directory contents
Product: [Fedora] Fedora Reporter: Michel Lind <michel>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/uu_ls
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-26 03:39:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2257190, 2257486    
Bug Blocks: 2257493, 2258211    

Description Michel Lind 2024-01-09 20:57:18 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_ls.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_ls-0.0.23-1.fc38.src.rpm

Description:
ls ~ (uutils) display directory contents.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-09 21:00:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6877146
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2257490-rust-uu_ls/fedora-rawhide-x86_64/06877146-rust-uu_ls/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-11 14:40:45 UTC
Package looks fine, but it doesn't install due to the missing package for the "selinux" crate:

Problem 1: conflicting requests
  - nothing provides (crate(selinux/default) >= 0.4.0 with crate(selinux/default) < 0.5.0~) needed by rust-uu_ls+selinux-devel-0.0.23-1.fc40.noarch
 Problem 2: package rust-uu_ls+feat_selinux-devel-0.0.23-1.fc40.noarch requires crate(uu_ls/selinux) = 0.0.23, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(selinux/default) >= 0.4.0 with crate(selinux/default) < 0.5.0~) needed by rust-uu_ls+selinux-devel-0.0.23-1.fc40.noarch

Comment 3 Michel Lind 2024-01-12 03:11:44 UTC
Ah, yes, I've now marked it as being blocked on rust-selinux

Comment 4 Fabio Valentini 2024-01-25 22:34:54 UTC
Looks good now, thank you!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fabio Valentini 2024-01-25 22:35:52 UTC
> - latest version of the crate is packaged

I forgot to change this - 0.0.24 is out, but packaging v0.0.23 is fine for now to match other uu_* crates that are currently in Fedora.

Comment 6 Fedora Admin user for bugzilla script actions 2024-01-26 03:21:03 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_ls

Comment 7 Fedora Update System 2024-01-26 03:33:01 UTC
FEDORA-2024-11a556405d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-11a556405d

Comment 8 Fedora Update System 2024-01-26 03:39:25 UTC
FEDORA-2024-11a556405d has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-01-26 22:43:43 UTC
FEDORA-2024-25180718b5 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-25180718b5

Comment 10 Fedora Update System 2024-01-26 22:44:03 UTC
FEDORA-2024-8c6f0c3ac7 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8c6f0c3ac7

Comment 11 Fedora Update System 2024-01-27 02:34:22 UTC
FEDORA-2024-8c6f0c3ac7 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8c6f0c3ac7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8c6f0c3ac7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-27 03:05:16 UTC
FEDORA-2024-25180718b5 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-25180718b5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-25180718b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-01-31 02:03:58 UTC
FEDORA-2024-8c6f0c3ac7 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-02-01 01:24:02 UTC
FEDORA-2024-25180718b5 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.