Bug 225836
| Summary: | Merge Review: gnome-speech | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | davidz, mclasen, musuruan, panemade | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-10-13 06:37:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 18:54:38 UTC
I was passing by and I noticed some problems. I don't have the time for a formal review though. Maybe later. The following line at the beginning of the spec file is not needed: %define po_package gnome-speech It should be deleted. %makeinstall macro should not be used, if possible: http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28package%29%7C%28review%29#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 If it is not possible you should put a remark to avoid reports from people like me :) gnome-speech-espeak subpackage should require espeak. I think you should also make a separate subpackage for festival like you did with espeak. It should be possible to use espeak without having festival installed. Therefore the Requires tag for festival should be moved from the main package. Are you sure gettext is required? I cannot see no translation neither in the original source package nor in the spec file. HTH. Adding current maintainer to CC list. Ping? Are these issues I pointed out addressed? There have been 9 releases of gnome-speech after I submitted my notes, but all the problems are still there. Created attachment 452079 [details]
spec cleanup
Please commit this git cleanup patch or allow to commit it.
Applied and built in gnome-speech-0.4.25-4.fc15 APPROVED. |