Fedora Merge Review: gnome-speech
Initial Owner: firstname.lastname@example.org
I was passing by and I noticed some problems. I don't have the time for a formal
review though. Maybe later.
The following line at the beginning of the spec file is not needed:
%define po_package gnome-speech
It should be deleted.
%makeinstall macro should not be used, if possible:
If it is not possible you should put a remark to avoid reports from people like
gnome-speech-espeak subpackage should require espeak.
I think you should also make a separate subpackage for festival like you did
with espeak. It should be possible to use espeak without having festival
installed. Therefore the Requires tag for festival should be moved from the main
Are you sure gettext is required? I cannot see no translation neither in the
original source package nor in the spec file.
Adding current maintainer to CC list.
Ping? Are these issues I pointed out addressed? There have been 9 releases of gnome-speech after I submitted my notes, but all the problems are still there.
Created attachment 452079 [details]
Please commit this git cleanup patch or allow to commit it.
Applied and built in gnome-speech-0.4.25-4.fc15