Bug 225838
| Summary: | Merge Review: gnome-system-monitor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | sandmann |
| Target Milestone: | --- | Flags: | dakingun:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-11 01:28:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 18:55:04 UTC
Good:
* Package name conforms to the Fedora Naming Guidelines
* Sources, Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.
NEEDSWORK:
According to the packaging guildlines on rpm scriplets,
* The post and postun Requires on desktop-file-utils is not necessary
* call to scrollkeeper-update in post section is inclomplete, should be called like;
"scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :"
* I believe the "add-category X-Redhat-Base" is no longer necessary for the
desktop file install.
A couple of other minor nitpicks;
* You can pass the "--disable-schemas-install" option to the configure script,
without needing to set and unset the GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL env.
* There are a number of rpmlint warnings/errors which I believe can be ignored;
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.src.rpm
W: gnome-system-monitor unversioned-explicit-obsoletes gtop
[deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.x86_64.rpm
E: gnome-system-monitor obsolete-not-provided gtop
W: gnome-system-monitor no-documentation
W: gnome-system-monitor non-conffile-in-etc
/etc/gconf/schemas/gnome-system-monitor.schemas
Another needswork; g-s-monitor use of %makeinstall macro should be changed to "make DESTDIR=$RPM_BUILD_ROOT install", according to the guildelines @ http://www.fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 > * call to scrollkeeper-update in post section is inclomplete, should be called
> like; "scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :"
There is no need to slavishly follow the examples in the guidelines to the letter.
The current call works fine
* The post and postun Requires on desktop-file-utils is not necessary There is no such requires in my checkout of the spec file ? (In reply to comment #4) > * The post and postun Requires on desktop-file-utils is not necessary > > There is no such requires in my checkout of the spec file ? Yeah, it's truly not there, i must have confused it with some other package. * Thu Feb 8 2007 Matthias Clasen <mclasen> - 2.17.6-2 - Remove an obsolete Obsoletes: - Don't add X-Redhat-Base to the desktop file anymore rpmlint now silent on srpm, and gives warnings (which can be ignored) on the binary [deji@agape reviews]$ rpmlint gnome-system-monitor-2.17.6-2.fc7.x86_64.rpm W: gnome-system-monitor no-documentation W: gnome-system-monitor non-conffile-in-etc /etc/gconf/schemas/gnome-system-monitor.schemas APPROVED. Sorry, the owner actually have a name. This is done. |