Bug 225880

MUSTFIX:
- package must not own
/usr/share/locale/*
and
/usr/share/locale/*/LC_MESSAGES

Package should use %find_lang


- Source0 is not an absolute URL


- *-devel contains *.pc
=> Requires: pkgconfig

Fixed in hal-0.5.8.1-8.fc7

Issues:

* use RPM_BUILD_ROOT or buildroot

*
BuildRequires: perl-XML-Parser
should certainly be replaced by
BuildRequires: perl(XML::Parser)

* Missing
Requires(post): /sbin/ldconfig
Requires(pre): /usr/sbin/useradd
Requires(postun): gawk, grep, coreutils, /sbin/ldconfig
I guessed that triggerpostun is associated with Requires(postun), maybe this
is wrong.

* There are no static libraries, the -devel %description should be updated

* /etc/dbus-1/system.d/hal.conf should certainly be %config(noreplace)

* Why is %doc commented out? And also
%{_datadir}/doc/hal-%{version}/conf/*
seems wrong to me but it's not completely obvious.

* remove Application; X-Red-Hat-Base; from desktop file Categories
remove X-Desktop-File-Install-Version=0.10 from desktop file

* --vendor should be fedora and not redhat. There is a cryptic comment
saying that it shouldn't change during release but I guess we are 
between releases...

* shouldn't hal-info be put in another package?

Suggestions:

* replace %defattr(-,root,root) with %defattr(-,root,root,-)

* replace
cp -f %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/
with
cp -p %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/hal/fdi/policy/10osvendor/
 


There is an issue of directory ownership for /usr/share/gtk-doc/html/,
but it is not obvious how to solve it.

In response to comment 3:

I've fixed most of this except making /etc/dbus-1/system.d/hal.conf
%config(noreplace). I've made it %config however as
/etc/dbus-1/system.d/hal.conf isn't a configuration at all; however some
developers like to tweak it around and as such their changes will be saved as
.rpmsave.

I've also cleaned up the %files sections of the spec file - please review if I
broke anything and if you think the spec file looks good now. Thanks.

This will appear in tomorrows Rawhide and I've uploaded the spec file and SRPM here

 http://people.redhat.com/davidz/hal.spec
 http://people.redhat.com/davidz/hal-0.5.9-0.git20070218.fc7.src.rpm

Thanks for reviewing this.

(In reply to comment #4)
> In response to comment 3:
> 
> I've fixed most of this except making /etc/dbus-1/system.d/hal.conf
> %config(noreplace). I've made it %config however as
> /etc/dbus-1/system.d/hal.conf isn't a configuration at all; 

It defines the security policy of HAL, it is an obvious config
file. You may prefer to keep it under the packager responsibility,
but it is a config file. I am personally fine with having this file
%config, seems like a good compromise.

I think that 
%{_sysconfdir}/rc.d/init.d/haldaemon
shouldn't be %config.
Maybe you could use  %_initrddir for that file.

The Application category in .desktop file is deprecated.

What about putting hal-info in another package?

hal-info is a separate package by now; I agree that the invalid Application
category should be removed fron the desktop file; should probably be fixed
upstream though, not worth carrying a patch for.

The hal-gnome package (and with it the desktop file) is gone now.

Hal has been deprecated in rawhide today, so I'm closing this Merge Review as WONTFIX.

This bug just popped out when I searched for packages under review but looks like this package was retired already.

Dropping the flag fedora-review?