Bug 2258867
| Summary: | Review Request: opentofu - OpenTofu lets you declaratively manage your cloud infrastructure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | mtarsel, ngompa13, package-review | ||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-02-05 20:29:32 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2024-01-17 19:05:40 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6913321 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258867-opentofu/fedora-rawhide-x86_64/06913321-opentofu/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - License file operator_license.go is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Documentation size is 1757358 bytes in 84 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is not quite correctly handled * No serious issues from rpmlint The only issue I see missing is that since you're bundling for now (as we discussed in person, you want to do the devendoring later), you'll need to document all the license tags for all the bundled components in the License field. See: https://docs.fedoraproject.org/en-US/legal/license-field/ Spec URL: https://mikel.olasagasti.info/tmp/fedora/opentofu.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/opentofu-1.6.1-1.fc39.src.rpm - Updated to 1.6.1 - Added license tags for all components, checked with licensei Created attachment 2015226 [details]
The .spec file difference from Copr build 6913321 to 6987105
Copr build: https://copr.fedorainfracloud.org/coprs/build/6987105 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258867-opentofu/fedora-rawhide-x86_64/06987105-opentofu/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - License file operator_license.go is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Documentation size is 1758902 bytes in 84 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This looks good to me now. PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/opentofu FEDORA-2024-447f7abe5d (opentofu-1.6.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-447f7abe5d FEDORA-2024-447f7abe5d (opentofu-1.6.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |