Bug 225895
| Summary: | Merge Review: icon-slicer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | David Zeuthen <davidz> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davidz, mclasen, roozbeh, rstrode |
| Target Milestone: | --- | Flags: | roozbeh:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-02 13:44:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:04:42 UTC
Random first notes:
* change BuildPrereq to BuildRequires
* change Release to integer value, perhaps also using %{?dist}
* change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* License field says MIT, but there is a copy of GPL in the tarball named COPYING!
* ship at least ChangeLog and AUTHORS in %doc
* use make DESTDIR=$RPM_BUILD_ROOT install instead of %makeinstall
* change %defattr(-,root,root) to %defattr(-,root,root,-)
* use make %{?_smp_mflags} instead of make
* provide URL field
* provide complete URL of source tarball in the Source field
Ray, do any of the split art packages still BR icon-slicer ? If not, we should just drop it. the icon sheets/ icon slicer stuff was just plain weird. I packaged the icons split up from the get go. |