Bug 225895 - Merge Review: icon-slicer
Merge Review: icon-slicer
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Zeuthen
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 14:04 EST by Nobody's working on this, feel free to take it
Modified: 2013-03-05 22:49 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-10-02 09:44:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
roozbeh: fedora‑review-

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 14:04:42 EST
Fedora Merge Review: icon-slicer

Initial Owner: davidz@redhat.com
Comment 1 Roozbeh Pournader 2007-02-06 05:38:36 EST
Random first notes:
* change BuildPrereq to BuildRequires
* change Release to integer value, perhaps also using %{?dist}
* change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* License field says MIT, but there is a copy of GPL in the tarball named COPYING!
* ship at least ChangeLog and AUTHORS in %doc
* use make DESTDIR=$RPM_BUILD_ROOT install instead of %makeinstall
* change %defattr(-,root,root) to %defattr(-,root,root,-)
* use make %{?_smp_mflags} instead of make
* provide URL field
* provide complete URL of source tarball in the Source field
Comment 2 Matthias Clasen 2007-10-02 00:02:28 EDT
Ray, do any of the split art packages still BR icon-slicer ?

If not, we should just drop it.
Comment 3 Ray Strode [halfline] 2007-10-02 09:44:53 EDT
the icon sheets/ icon slicer stuff was just plain weird.  I packaged the icons
split up from the get go.

Note You need to log in before you can comment on or make changes to this bug.