Bug 2259019
| Summary: | Review Request: rust-poly1305 - Poly1305 universal hash function and message authentication code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mikel Olasagasti Uranga <mikel> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/poly1305 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-01-20 12:09:15 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2259330 | ||||||
| Attachments: |
|
||||||
|
Description
Mikel Olasagasti Uranga
2024-01-18 16:47:35 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6915865 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259019-rust-poly1305/fedora-rawhide-x86_64/06915865-rust-poly1305/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks like the tarball also includes a bunch of data files that are used for fuzz testing - can you exclude those data files from the built package?
Adding something like
%exclude %{crate_instdir}/fuzz
%exclude %{crate_instdir}/src/fuzz
to the %files list of the "devel" subpackage should do it.
Spec URL: https://mikel.olasagasti.info/tmp/fedora/rust-poly1305.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/rust-poly1305-0.8.0-1.fc39.src.rpm Added exclude for %{crate_instdir}/fuzz and %{crate_instdir}/src/fuzz The other option would be to rm the files in %prep. Created attachment 2009262 [details]
The .spec file difference from Copr build 6915865 to 6921336
Copr build: https://copr.fedorainfracloud.org/coprs/build/6921336 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259019-rust-poly1305/fedora-rawhide-x86_64/06921336-rust-poly1305/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thank you, looks good to me now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-poly1305 FEDORA-2024-45ddede96c has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-45ddede96c FEDORA-2024-45ddede96c has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |