Bug 2259045
| Summary: | Review Request: rust-v_htmlescape - Simd optimized HTML escaping code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/v_htmlescape | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-02-12 20:54:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2259044 | ||
| Bug Blocks: | 2211172 | ||
|
Description
Michel Lind
2024-01-18 19:54:34 UTC
Note: re-review of #1715567 since the package was retired Copr build: https://copr.fedorainfracloud.org/coprs/build/6916125 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259045-rust-v_htmlescape/fedora-rawhide-x86_64/06916125-rust-v_htmlescape/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-v_htmlescape Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It looks like the tests use x86-specific intrinsics and don't compile on non-x86_64 architectures. You will need to either run tests on x86_64 only or patch them to correctly cfg-gate the tests that use x86 specific Rust functionality. scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=112060345 Updated, thanks. Scratch build now passes https://koji.fedoraproject.org/koji/taskinfo?taskID=112356913 Looks good to me now, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (disabled on non-x86 arches with explanation) - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: (skip those that are not relevant for unretirements) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Thanks! Unretirement ticket filed: https://pagure.io/releng/issue/11916 FEDORA-2024-2d9a516fde (rust-v_htmlescape-0.15.8-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2d9a516fde FEDORA-2024-2d9a516fde (rust-v_htmlescape-0.15.8-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-eb2280e1a6 (rust-v_htmlescape-0.15.8-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-eb2280e1a6 FEDORA-2024-6d5e2a6ad6 (rust-v_htmlescape-0.15.8-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d5e2a6ad6 FEDORA-2024-eb2280e1a6 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-eb2280e1a6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-eb2280e1a6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-6d5e2a6ad6 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6d5e2a6ad6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d5e2a6ad6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-eb2280e1a6 (rust-v_htmlescape-0.15.8-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-6d5e2a6ad6 (rust-v_htmlescape-0.15.8-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |